fix: match hidden directories for path exclusions #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Globstars don't match paths with hidden directories by default: isaacs/minimatch#51
This means the default
exclude
option of**/node_modules/**
will fail for projects anchored at a path like /foo/.bar/. E.g. it is fairly common for developers to mimic FHS directory structures in their home directory using.local
, meaning repositories are cloned within~/.local/src/
, which would not be matched by the default globstar. In all likelihood most users would expect matching hidden directories to be the default behaviour.