Fix folder pattern #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 168 168
Branches 41 41
=========================================
Hits 168 168
Continue to review full report at Codecov.
|
|
Can you add test? |
|
sure thing |
Paths computed from node's path modules often do not end in with a slash, this replacement fails if there is no slash... which it was not meant to. (we already know the path points to a directory...
ricardogobbosouza
approved these changes
Nov 5, 2020
alexander-akait
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths computed from node's path modules often do not end in with a slash, this replacement fails if there is no slash... which it was not meant to. (we already know the path points to a directory...
This PR contains a:
Motivation / Use-Case
Keep defaults sane.
Additional Info