fix(fail-on-error): show eslint errors when failOnError is disabled (#85

)
webpack-contrib · Feb 17, 2021 · 69be533 · 69be533
1 parent 4930a6f
commit 69be533
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -145,6 +145,9 @@ class ESLintWebpackPlugin {
         if (errors && options.failOnError) {
           // @ts-ignore
           compilation.errors.push(errors);
+        } else if (errors && !options.failOnError) {
+          // @ts-ignore
+          compilation.warnings.push(errors);
         }
 
         if (generateReportAsset) {

diff --git a/test/fail-on-error.test.js b/test/fail-on-error.test.js
@@ -11,6 +11,17 @@ describe('fail on error', () => {
     });
   });
 
+  it('should emit warnings when disabled', (done) => {
+    const compiler = pack('error', { failOnError: false });
+
+    compiler.run((err, stats) => {
+      expect(err).toBeNull();
+      expect(stats.hasErrors()).toBe(false);
+      expect(stats.hasWarnings()).toBe(true);
+      done();
+    });
+  });
+
   it('should correctly indentifies a success', (done) => {
     const compiler = pack('good', { failOnError: true });