Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add anchor tags to options table #609

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

diegofaria
Copy link
Contributor

What kind of change does this PR introduce?
Docs.

Did you add tests for your changes?
No

Summary
Just improving docs.

Does this PR introduce a breaking change?
No

README.md Outdated
|**`sourceMap`**|`{Boolean}`|`false`|Enable/Disable Sourcemaps|
|**`camelCase`**|`{Boolean\|String}`|`false`|Export Classnames in CamelCase|
|**`importLoaders`**|`{Number}`|`0`|Number of loaders applied before CSS loader|
|**[`root`](https://github.com/webpack-contrib/css-loader#root)**|`{String}`|`/`|Path to resolve URLs, URLs starting with `/` will not be translated|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍 , but could you please check if [name](#root) works ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, it works 😄

@codecov
Copy link

codecov bot commented Sep 11, 2017

Codecov Report

Merging #609 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          10       10           
  Lines         371      371           
  Branches       87       87           
=======================================
  Hits          367      367           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0840c80...afb0060. Read the comment docs.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegofaria Thx 👍

@michael-ciniawsky michael-ciniawsky changed the title Improve docs usability docs(README): add anchor tags to options table Sep 12, 2017
@michael-ciniawsky michael-ciniawsky merged commit 7039740 into webpack-contrib:master Sep 12, 2017
@michael-ciniawsky michael-ciniawsky removed their assignment Sep 12, 2017
@diegofaria diegofaria deleted the patch-1 branch September 13, 2017 11:24
@michael-ciniawsky michael-ciniawsky removed this from the 0.28.9 milestone Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants