Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use compiler.inputFileSystem instead fs #205

Merged
merged 1 commit into from
Jan 29, 2018
Merged

feat: use compiler.inputFileSystem instead fs #205

merged 1 commit into from
Jan 29, 2018

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jan 16, 2018 •
edited by michael-ciniawsky
Loading

Notable Changes

Also it is improve perf, because webpack cache stats and other stuff (https://github.com/webpack/webpack/blob/efc576c8b744e7a015ab26f1f46932ba3ca7d4f1/lib/node/NodeEnvironmentPlugin.js#L14) using CachedInputFileSystem

Issues

@alexander-akait alexander-akait force-pushed the refactor-use-input-file-system branch from fe9c6d0 to 723b582 Compare January 16, 2018 16:25
michael-ciniawsky
michael-ciniawsky approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michael-ciniawsky michael-ciniawsky added this to the 4.3.1 milestone Jan 17, 2018
@michael-ciniawsky
Copy link
Member

@evilebottnawi Should we flag this as perf or feature instead (for the CHANGELOG) ?

@alexander-akait
Copy link
Member Author

@michael-ciniawsky o don't know 😄 and perf and feature and refactor 😄

@michael-ciniawsky michael-ciniawsky changed the title refactor: use compiler.inputFileSystem instead fs feat: use compiler.inputFileSystem instead fs Jan 17, 2018
@michael-ciniawsky michael-ciniawsky modified the milestones: 4.3.1, 4.4.0 Jan 17, 2018
@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Jan 17, 2018 •
edited
Loading

kk me neither, going with feat for now as long as nobody objects, so it definitely appears in theCHANGELOG 😛

@michael-ciniawsky
Copy link
Member

@evilebottnawi A rebase one more time please :) This is definitely ready right ?

michael-ciniawsky
michael-ciniawsky reviewed Jan 26, 2018
View reviewed changes
package.json
@@ -31,6 +31,7 @@
"babel-preset-es2015": "^6.6.0",
"chai": "^3.4.0",
"eslint": "^2.9.0",
"enhanced-resolve": "^3.4.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed as direct devDependency when webpack is already 'installed' ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky for tests locally

Copy link
Member

@michael-ciniawsky michael-ciniawsky Jan 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but enhanced-resolve is installed via webpack already and flatten in node_modules ? Not important... :). Could you please rebase/generate a new lockfile when time ?

@alexander-akait alexander-akait force-pushed the refactor-use-input-file-system branch from 723b582 to 757bd04 Compare January 29, 2018 09:38
@alexander-akait
Copy link
Member Author

@michael-ciniawsky done 👍

@michael-ciniawsky michael-ciniawsky merged commit 158f821 into master Jan 29, 2018
@michael-ciniawsky michael-ciniawsky deleted the refactor-use-input-file-system branch January 29, 2018 19:46
@michael-ciniawsky michael-ciniawsky removed this from the 4.5.0 milestone Feb 8, 2018
This was referenced Feb 8, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@joshwiens joshwiens Awaiting requested review from joshwiens

Assignees
No one assigned
Labels
semver: Patch type: Feature type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-akait @michael-ciniawsky