Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow multiple outputs for same input #136

Closed
wants to merge 2 commits into from
Closed

feat: allow multiple outputs for same input #136

wants to merge 2 commits into from

Conversation

jdeniau
Copy link

@jdeniau jdeniau commented Jul 13, 2017

Fixes #99

@michael-ciniawsky michael-ciniawsky changed the title allow multiple outputs for same input feat: allow multiple outputs for same input Oct 5, 2017
@michael-ciniawsky
Copy link
Member

@jdeniau Please rebase to latest master, so we can triage this further :)

@jdeniau jdeniau force-pushed the fix-sameInputMultipleOutputs branch from b737e64 to dea53d5 Compare October 6, 2017 05:13
@jdeniau
Copy link
Author

jdeniau commented Oct 6, 2017

@michael-ciniawsky done

@michael-ciniawsky michael-ciniawsky added this to the 4.2.0 milestone Oct 6, 2017
joshwiens
joshwiens reviewed Oct 6, 2017
View reviewed changes
src/writeFile.js
[hash]: true
[file.webpackTo]: {
[hash]: true
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a specific use case that can't be accomplished using copyUnmodified.

Based on the test case below, you could do the same thing without adding new functionality.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the test to add a transform method to the plugin. This way it does not work even if you add copyUnmodified option.

For the record, when I had the bug, it was by copying the same file with the same transformation (basically babel + uglify) in two different locations for history purpose (two different files became only one, but both are referenced)

@jdeniau
Copy link
Author

jdeniau commented Oct 6, 2017 •
edited
Loading

For the record the test is failing in Node 4 only with a gcc bug, I think you can restart it and it should work.

Thanks

@joshwiens
Copy link
Member

Triggered a rebuild on Travis.

@alexander-akait
Copy link
Member

Duplicate #165

@michael-ciniawsky michael-ciniawsky removed this from the 4.3.0 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwiens joshwiens joshwiens left review comments

Assignees
No one assigned
Labels
semver: Minor status: Declined type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdeniau @michael-ciniawsky @joshwiens @alexander-akait