Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated minRatio verbiage #141

Merged
merged 4 commits into from
Jan 3, 2020

Conversation

hecktarzuli
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

#130

@hecktarzuli hecktarzuli mentioned this pull request Dec 10, 2019
4 tasks
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files           2        2           
  Lines          78       78           
  Branches       27       27           
=======================================
  Hits           77       77           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf22024...7a78fa1. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@alexander-akait
Copy link
Member

Can you update lock file to avoid problems with audit?

@hecktarzuli
Copy link
Contributor Author

Sorry, I don't follow. I just updated the README.md, what lock file and why?

@alexander-akait
Copy link
Member

@hecktarzuli CI failed because security problem in node_modules, need regenerate https://github.com/webpack-contrib/compression-webpack-plugin/blob/master/package-lock.json, just rm -r package-lock.json and npm i again and send a new lock file in this PR

@hecktarzuli
Copy link
Contributor Author

hecktarzuli commented Dec 12, 2019

Looks like it failed again. Honestly, I've already spent way too much time on this. I just wanted to help you out and update your doc but this has been a pain in the butt. Do what you want with this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants