Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping need for META_WEBOS_LAYER etc to be set #28

Open
rossburton opened this issue Dec 18, 2023 · 5 comments
Open

Consider dropping need for META_WEBOS_LAYER etc to be set #28

rossburton opened this issue Dec 18, 2023 · 5 comments

Comments

@rossburton
Copy link

As you control meta-webos, there's no need for the recipes to expect that META_WEBOS_LAYER has been set. This being a requirement makes it tricky to build webos outside of build-webos, as these variables also need to be set by hand.

META_WEBOS_LAYER can be removed seamlessly by simply setting it in meta-webos/conf/layer.conf:

META_WEBOS_LAYER := "${LAYERDIR}"

There's currently a single user of META_OE_LAYER. Arguably this could be added to meta-oe too, or the recipe restructured to avoid that need (for example, a clangifier BBCLASSEXTEND could work).
shr-project pushed a commit to shr-project/meta-webosose that referenced this issue Jan 5, 2024
@hieunv0828 @shr-project
webos: Initialize META_WEBOS_LAYER, META_OE_LAYER values
a75fee9 
:Release Notes:
Set META_WEBOS_LAYER, META_OE_LAYER variables to build webos
outside of build-webos

:Detailed Notes:
For Yocto autobuilder to build webos-image without using build-webos
script. META_WEBOS_LAYER and META_OE_LAYER need to be set by hand.
These variables are used inside classes, recipes in meta-webos.
Initialize values in layer.conf, and the MCF script can override them.

:Testing Performed:
Only build tested

:QA Notes:
N/A

:Issues Addressed:
[WRQ-6441] CCC: Initialize META_WEBOS_LAYER, META_OE_LAYER values
[WRQ-6119] Consider dropping need for META_WEBOS_LAYER webosose#28

Change-Id: Ic5abe4cb0eb09c2a0129daeb4f4f9ded2ecaa5a6
@shr-project shr-project mentioned this issue Jan 5, 2024
Closed
@shr-project
Copy link
Contributor

shr-project commented Jan 5, 2024 •
edited
Loading

@hieunv0828 Can you please reply here with the explanation why BBCLASSEXTEND didn't work together with multilib?

I've shared PR for this and #27, so that Ross can test the same fixes which are going to be merged internally on AB, without the need to recreate the commits from the diff you've shared in comment (which is also old version not using TOKEN) or creating his own commit for lemon backport. Do you know when there will be next OSE release on github?

@jaeyoonjung
Copy link
Contributor

The next OSE release is planned at the week of Jan 15th.

shr-project pushed a commit to shr-project/meta-webosose that referenced this issue Jan 5, 2024
@hieunv0828 @shr-project
webos: Initialize META_WEBOS_LAYER, META_OE_LAYER values
b1c8ec2 
:Release Notes:
Set META_WEBOS_LAYER, META_OE_LAYER variables to build webos
outside of build-webos

:Detailed Notes:
For Yocto autobuilder to build webos-image without using build-webos
script. META_WEBOS_LAYER and META_OE_LAYER need to be set by hand.
These variables are used inside classes, recipes in meta-webos.
Initialize values in layer.conf, and the MCF script can override them.

:Testing Performed:
Only build tested

:QA Notes:
N/A

:Issues Addressed:
[WRQ-6441] CCC: Initialize META_WEBOS_LAYER, META_OE_LAYER values
[WRQ-6119] Consider dropping need for META_WEBOS_LAYER webosose#28

Change-Id: Ic5abe4cb0eb09c2a0129daeb4f4f9ded2ecaa5a6
@hieunv0828
Copy link
Contributor

Hi @rossburton: As Martin's mentioned, the BBCLASSEXTEND didn't work together with multilib. I tried creating new simple class (extend.bbclass) and set BBCLASSEXTEND = "extend", but the Bitbake can't extend an extended recipe (https://bugzilla.yoctoproject.org/show_bug.cgi?id=13424), so I can't bitbake lib32-googletest-extend.
We set META_OE_LAYER variable in meta-webos/conf/layer.conf:

META_OE_LAYER ??= "${@'${BBFILE_PATTERN_openembedded-layer}'[1:-1]}"

Then I can build webos outside of build-webos. So you can remove hardcode two paths in JSON configs after #30 is merged.

shr-project pushed a commit to shr-project/meta-webosose that referenced this issue Jan 17, 2024
@hieunv0828 @shr-project
webos: Initialize META_WEBOS_LAYER, META_OE_LAYER values
6e867bc 
:Release Notes:
Set META_WEBOS_LAYER, META_OE_LAYER variables to build webos
outside of build-webos

:Detailed Notes:
For Yocto autobuilder to build webos-image without using build-webos
script. META_WEBOS_LAYER and META_OE_LAYER need to be set by hand.
These variables are used inside classes, recipes in meta-webos.
Initialize values in layer.conf, and the MCF script can override them.

:Testing Performed:
Only build tested

:QA Notes:
N/A

:Issues Addressed:
[WRQ-6441] CCC: Initialize META_WEBOS_LAYER, META_OE_LAYER values
[WRQ-6119] Consider dropping need for META_WEBOS_LAYER webosose#28

Change-Id: Ic5abe4cb0eb09c2a0129daeb4f4f9ded2ecaa5a6
shr-project pushed a commit to shr-project/meta-webosose that referenced this issue Jan 17, 2024
@hieunv0828 @shr-project
webos: Initialize META_WEBOS_LAYER, META_OE_LAYER values
dcd0261 
:Release Notes:
Set META_WEBOS_LAYER, META_OE_LAYER variables to build webos
outside of build-webos

:Detailed Notes:
For Yocto autobuilder to build webos-image without using build-webos
script. META_WEBOS_LAYER and META_OE_LAYER need to be set by hand.
These variables are used inside classes, recipes in meta-webos.
Initialize values in layer.conf, and the MCF script can override them.

:Testing Performed:
Only build tested

:QA Notes:
N/A

:Issues Addressed:
[WRQ-6441] CCC: Initialize META_WEBOS_LAYER, META_OE_LAYER values
[WRQ-6119] Consider dropping need for META_WEBOS_LAYER webosose#28

Change-Id: Ic5abe4cb0eb09c2a0129daeb4f4f9ded2ecaa5a6
ywbyun0815 pushed a commit that referenced this issue Jan 19, 2024
@hieunv0828 @ywbyun0815
webos: Initialize META_WEBOS_LAYER, META_OE_LAYER values
f81893d 
:Release Notes:
Set META_WEBOS_LAYER, META_OE_LAYER variables to build webos
outside of build-webos

:Detailed Notes:
For Yocto autobuilder to build webos-image without using build-webos
script. META_WEBOS_LAYER and META_OE_LAYER need to be set by hand.
These variables are used inside classes, recipes in meta-webos.
Initialize values in layer.conf, and the MCF script can override them.

:Testing Performed:
Only build tested

:QA Notes:
N/A

:Issues Addressed:
[WRQ-6441] CCC: Initialize META_WEBOS_LAYER, META_OE_LAYER values
[WRQ-6119] Consider dropping need for META_WEBOS_LAYER #28

Cherry-picked-from-commit: e187913
Cherry-picked-from-branch:
@hieunv0828
Copy link
Contributor

@rossburton
We have already set META_WEBOS_LAYER and META_OE_LAYER in meta-webos/conf/layer.conf on master branch (f81893d)
You can remove the hard code these variables in autobuilder configurations.

@jaeyoonjung
Copy link
Contributor

@rossburton <
f81893d
This fixes this issue. Please check it out and move forward to next step. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webos: Initialize META_WEBOS_LAYER, META_OE_LAYER values shr-project/meta-webosose
4 participants
@rossburton @shr-project @hieunv0828 @jaeyoonjung