Bubble unsafe up from Pixels::from_raw_pointer() #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-guyon
force-pushed
the
pixels_unsafe_set_ptr
branch
from
203422d to
40a73c3
Compare
Also tag Decoder::set_io_raw() as unsafe. Add fn safety section to comply with https://rust-lang.github.io/rust-clippy/master/index.html#/missing_safety_doc
y-guyon
force-pushed
the
pixels_unsafe_set_ptr
branch
from
40a73c3 to
ee18144
Compare
riking
reviewed
May 20, 2024
| self.io = Some(Box::new(DecoderRawIO::create(data, size))); | ||
| /// # Safety | ||
| /// | ||
| /// This has an unsafe block and is intended for use only from the C API. |
There was a problem hiding this comment.
Suggested change
| /// This has an unsafe block and is intended for use only from the C API. | |
| /// This function should be called from the C API entrypoints. The function never fails. | |
| /// | |
| /// # Safety | |
| /// | |
| /// The memory at `data` must be valid for `size` bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tag Decoder::set_io_raw() as unsafe.
Add fn safety section to comply with
https://rust-lang.github.io/rust-clippy/master/index.html#/missing_safety_doc