Fix returning failure from methods, and use "item" for lists #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two glitches introduced in a88bb0e where validation steps were inlined; the out-of-line steps returned "failure" but now that they're inlined they need to explicitly throw. My bad. Also, when referring to the contents of a list, the Infra term is "items", so use that and linkify it, rather than the more generic "elements" term. We more consistently use "elements" when referring to the contents of a tensor anyway.
|
@huningxin and @fdwr can you review and merge if this LG2U? Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Feb 18, 2025
SHA: fccaccb Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two glitches introduced in a88bb0e where validation steps were inlined; the out-of-line steps returned "failure" but now that they're inlined they need to explicitly throw. My bad.
Also, when referring to the contents of a list, the Infra term is "items", so use that and linkify it, rather than the more generic "elements" term. We more consistently use "elements" when referring to the contents of a tensor anyway.
Preview | Diff