Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define equality for lists and MLOperandDescriptors #813

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Feb 3, 2025

The list equality definition is intentionally written in the same style as the Infra definition for set equality; the algorithm can be removed once whatwg/infra#664 is settled.

Resolves #792


Preview | Diff

The list equality definition is intentionally written in the same
style as the Infra definition for set equality; the algorithm can be
removed once whatwg/infra#664 is settled.

Resolves webmachinelearning#792
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM sir.

@inexorabletash
Copy link
Member Author

@huningxin can you take a peek, and merge if it looks good? Thanks!

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huningxin huningxin merged commit d17fe35 into webmachinelearning:main Feb 15, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 15, 2025
SHA: d17fe35
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the equality branch February 15, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define equality for non-trivial data types
3 participants