change argmin/argmax to take scalar axis #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philloooo
commented
Jul 15, 2024
|
Note forced pushes make it harder to compare iterations in the Files tab 🔍😐, as the "Show changes since your last review" button doesn't work correctly. |
fdwr
approved these changes
Jul 16, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 18, 2024
SHA: 92ff390 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2024
This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2024
This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 23, 2024
This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2024
This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2024
This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 25, 2024
…ar axis, a=testonly Automatic update from web-platform-tests WebNN: Change argMin/argMax to take scalar axis This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567} -- wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450 wpt-pr: 47235
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 26, 2024
…ar axis, a=testonly Automatic update from web-platform-tests WebNN: Change argMin/argMax to take scalar axis This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567} -- wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450 wpt-pr: 47235
ChunMinChang
pushed a commit
to ChunMinChang/gecko-dev
that referenced
this pull request
Jul 26, 2024
…ar axis, a=testonly Automatic update from web-platform-tests WebNN: Change argMin/argMax to take scalar axis This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567} -- wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450 wpt-pr: 47235
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 26, 2024
…ar axis, a=testonly Automatic update from web-platform-tests WebNN: Change argMin/argMax to take scalar axis This CL changes argMin/argMax to take scalar axis to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML, TfLite and CoreML backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#724 Bug: 352359898 Change-Id: Iee68b568331570a6ea51fd17b2195c602d4cff59 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5721028 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Phillis Tang <phillis@chromium.org> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1331567} -- wpt-commits: acd785862cc0cd8a52e83ac6db95403e0e6e5450 wpt-pr: 47235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #629
axis, so now it becomes positional argument@fdwr @huningxin please take a look :)
Preview | Diff