Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gru/lstm: Fix missing/incorrect variables and options use #655

Merged
merged 1 commit into from
Apr 24, 2024
Merged

gru/lstm: Fix missing/incorrect variables and options use #655

merged 1 commit into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. gru/lstm: Fix missing/incorrect variables and options use 

    - In gru(), batchSize and numDirections were used without being
  defined. Define them.

- In lstm(), numDirections was initialized to 2 if the direction was
  "backward", should be 1.

- In gru() and gruCell(), options.activations was unconditionally
  added to the operator. Make this conditional.

- In lstm() and lstmCell(), options.activations were not added to the
  operator. Add if given.
    @inexorabletash
    inexorabletash committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1661bf9 View commit details
    Browse the repository at this point in the history