Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #393 for input() #394

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

zolkis
Copy link
Collaborator

@zolkis zolkis commented Jun 2, 2023

Remove extra parameter from 'create MLOperand' invocation.


Preview | Diff

…create MLOperand' invocation

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
@zolkis zolkis requested review from huningxin and anssiko June 2, 2023 13:34
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @zolkis !

@zolkis
Copy link
Collaborator Author

zolkis commented Jun 19, 2023

This needs to be merged, as it's a minor fix to a previous PR, and it is needed in zk-conventions-integration.

@wchao1115
Copy link
Collaborator

@zolkis Do you not have a permission to merge the change? Maybe I'm missing something here.

@anssiko anssiko merged commit cc34577 into webmachinelearning:main Jun 20, 2023
github-actions bot added a commit that referenced this pull request Jun 20, 2023
SHA: cc34577
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zolkis
Copy link
Collaborator Author

zolkis commented Jun 20, 2023

@zolkis Do you not have a permission to merge the change? Maybe I'm missing something here.

No, I don't, and I should not have. Editors and Anssi can merge PRs AFAICT.

@anssiko
Copy link
Member

anssiko commented Jun 20, 2023

I merged this and modified the commit message a bit for clarity. Only editors and the chair can write to main currently. We can discuss if we want to adjust this policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants