Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing TAG review issue#133, 134, and 137 #144

Merged
merged 2 commits into from
Feb 21, 2021
Merged

Conversation

wchao1115
Copy link
Collaborator

@wchao1115 wchao1115 commented Feb 15, 2021


Preview | Diff

@wchao1115
Copy link
Collaborator Author

index.bs Show resolved Hide resolved
@anssiko
Copy link
Member

anssiko commented Feb 18, 2021

@cynthia do you prefer to be explicitly requested for review for these PRs that address TAG feedback?

@cynthia
Copy link

cynthia commented Feb 19, 2021

@anssiko Not necessarily, but I would like to know which points are acknowledged as valid issues. (and how the group plans to address it, I have subscribed to some of them but haven't seen much aside from the issue being opened)

@anssiko
Copy link
Member

anssiko commented Feb 19, 2021

@cynthia the proposed plan of record is to open PRs to address each valid webnn tag-tracker issue similarly to this PR. I’m hearing we won’t request/block on your PR review, but rather post a summary of all the changes to the master TAG review issue once done with all if it, so the TAG can have a group discussion and see if you’re satisfied with our response.

If there are some specific clarifying questions we’ll ask you about them explicitly in respective issues or PRs. For thorny issues, if any, we may invite you to join our call.

@cynthia sounds good? Thanks for your insights!

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @wchao1115 !

@wchao1115 wchao1115 merged commit 4db4c69 into master Feb 21, 2021
@wchao1115 wchao1115 deleted the wchao_tag_review branch February 21, 2021 02:08
@cynthia
Copy link

cynthia commented Feb 21, 2021

post a summary of all the changes to the master TAG review issue once done

Sounds good to me. I'll subscribe myself to some of the more contentious issues - feel free to mention me if you need input on specific issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants