Refactor the Facial Landmark Detection example to fetch in parallel #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This model separates each constant value into a separate NumPy file which needs to be fetched. This change refactors the graph construction so that these fetches can happen in parallel rather than waiting for each fetch to complete before building that graph layer. This is an experiment to determine whether it would be more ergonomic for the graph builder function to accept promises so that this kind of code can be written without the careful placement of awaits demonstrated here.
|
@huningxin, @BruceDai, @Honry, please take a look. |
huningxin
approved these changes
Nov 11, 2023
Honry
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
LGTM % nits complained by lint. Thanks for the optimization! @reillyeon, Are you going to optimize the rest samples? If no, I can do that. :)
|
I've fixed the lint errors. Can you merge this change and then take a look at the rest of the samples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This model separates each constant value into a separate NumPy file which needs to be fetched. This change refactors the graph construction so that these fetches can happen in parallel rather than waiting for each fetch to complete before building that graph layer.
This is an experiment to determine whether it would be more ergonomic for the graph builder functions to accept promises so that this kind of code can be written without the careful placement of awaits demonstrated here.