Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group filters to attendance modal #5298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Jan 25, 2025

Description

Add buttons to filter registrations by membership in groups. Makes it easier to find friends attending events.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Filter buttons:
Screenshot 2025-01-25 at 08 31 07

With filter active:
Screenshot 2025-01-25 at 08 33 08

The groups shown are only groups you are a member of, sorted by the number of attendees in each group.

Testing

  • I have thoroughly tested my changes.

Works pretty well:)


Resolves ABA-1246

@eikhr eikhr added the enhancement Pull requests that make enhancements, instead of just purely new features label Jan 25, 2025
@eikhr eikhr requested review from ivarnakken and a team January 25, 2025 07:35
Copy link

linear bot commented Jan 25, 2025

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 11:56am

@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 25, 2025
Copy link
Contributor

@ollfkaih ollfkaih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks alright, but I think this might look too crowded on small laptops

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like!

Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 📈 📈

@eikhr eikhr force-pushed the filter-reg-by-group branch from 86b23c4 to 6a7dd74 Compare January 28, 2025 10:51
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added some other excluded groups that you can add if you want

app/components/UserAttendance/GroupFilter.tsx Show resolved Hide resolved
Co-authored-by: Falk Elvedal Bruskeland <66320400+falbru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants