-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group filters to attendance modal #5298
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks alright, but I think this might look too crowded on small laptops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 📈 📈
app/components/UserAttendance/AttendanceModalContent.module.css
Outdated
Show resolved
Hide resolved
86b23c4
to
6a7dd74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added some other excluded groups that you can add if you want
Co-authored-by: Falk Elvedal Bruskeland <66320400+falbru@users.noreply.github.com>
Description
Add buttons to filter registrations by membership in groups. Makes it easier to find friends attending events.
Result
Caution
Make sure your images do not contain any real user information.
Filter buttons:
With filter active:
The groups shown are only groups you are a member of, sorted by the number of attendees in each group.
Testing
Works pretty well:)
Resolves ABA-1246