Rename event deadlines #5273
Rename event deadlines #5273
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ivarnakken
added
approved
| @@ -126,8 +126,8 @@ const NormalOrInfiniteStatusType: React.FC<NormalOrInfiniteStatusTypeProps> = ({ | |||
| <div className={styles.subSection}> | |||
| <Field | |||
| key="unregistrationDeadline" | |||
There was a problem hiding this comment.
The variable names "unregistrationsDeadline" and "unregistrationDeadlineHours" are also a bit confusing. I could change "unregistrationDeadline" to "unregistrationPenaltyDeadline" or would that require a lot of changes to the backend as well? Maybe not worth the time?
There was a problem hiding this comment.
Agree that they are confusing! unregistrationPenaltyDeadline makes a lot more sense, or else those two just sound like the same thing. I'd say change it if it doesn't take you a lot of time ^^
There was a problem hiding this comment.
I tried changing it only in the frontend, but it breaks since the variable name is used for the model in the backend. I dont dare touch it alone hehe, but maybe someone can help me with it at the next meeting:)
There was a problem hiding this comment.
Yeah, it would be great if you change it:) Should work if you just change the variable name in the backend at the same time, but perhaps we can merge this first and make a new PR
|
Quick comment before my plane takes off (Trondheim 🔜): looks great, only thing I would change is "arrangementstart" to "arrangementsstart" (missing "s" but it's a small thing) (that is the most "pirk" comment I've ever written so feel free to choose if it's worth your time XD). Nice job! <3 |
Description
Changed labels for deadlines when creating/editing events.
Result
'Avregistreringsfrist' changed to 'Frist for prikk'.
'Avregistrering' and 'Registrering' changed to 'Avmelding' and 'Påmelding'.
More consistent with wording elsewhere
Easier to what separate deadlines means
More concise tooltips
Testing
Resolves ABA-1151