-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an "enhanced" theme selector for user settings #5251
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! 🤩
dbe5cbd
to
dff0992
Compare
Looks very nice! Just curious; do you know why cypress cant save changes? I could do it. |
nooo idea 😆 |
Doesn't work for me. I can press the save-button if I change the theme, but if I do not edit it the save button is deactivated :'( The button is also deactivated if I change it and then change back before I try to save Hmm upon further inspection what happened to me might be on purpose, in contrast to what happens to cypress |
This peaked my curiosity, so I spent some time testing it. Seems that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Great job 😍
Yes it's impossible to reproduce locally .. Thanks a lot for looking into it though! ❤️ |
Description
Not a fan of the radio buttons
Result
Testing
Changing themes works fine, and I've tested that changing it through the navbar updates the form (unlike before).
Resolves ABA-1212