Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an "enhanced" theme selector for user settings #5251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivarnakken
Copy link
Member

Description

Not a fan of the radio buttons

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After
image image
image image

Testing

  • I have thoroughly tested my changes.

Changing themes works fine, and I've tested that changing it through the navbar updates the form (unlike before).


Resolves ABA-1212

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review new-feature Pull requests that introduce a new feature labels Dec 25, 2024
@ivarnakken ivarnakken requested a review from a team December 25, 2024 09:48
@ivarnakken ivarnakken self-assigned this Dec 25, 2024
Copy link

linear bot commented Dec 25, 2024

Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 7:24pm

Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! 🤩

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Dec 25, 2024
@ivarnakken ivarnakken changed the title Introduce a "enhanced" theme selector for user settings Introduce an "enhanced" theme selector for user settings Dec 25, 2024
@emillub
Copy link
Contributor

emillub commented Jan 7, 2025

Looks very nice! Just curious; do you know why cypress cant save changes? I could do it.

@ivarnakken
Copy link
Member Author

Just curious; do you know why cypress cant save changes? I could do it.

nooo idea 😆

@norbye
Copy link
Member

norbye commented Jan 7, 2025

Just curious; do you know why cypress cant save changes? I could do it.

nooo idea 😆

Doesn't work for me. I can press the save-button if I change the theme, but if I do not edit it the save button is deactivated :'(

The button is also deactivated if I change it and then change back before I try to save

Hmm upon further inspection what happened to me might be on purpose, in contrast to what happens to cypress

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Great job 😍

@ivarnakken
Copy link
Member Author

ivarnakken commented Jan 10, 2025

doesn't happen locally but for some reason it does with cypress

Yes it's impossible to reproduce locally ..

Thanks a lot for looking into it though! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features new-feature Pull requests that introduce a new feature review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants