-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement and show upptime status in footer #5235
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
export const fetchSystemStatus = createAsyncThunk( | ||
'status/fetch', | ||
async (): Promise<SystemStatus> => { | ||
const response = await fetch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very clean way of creating a fetching thunk, but it doesn't follow lego-webapp
convention. Also, I'm pretty sure the SystemStatus.FETCH
won't work now, meaning loading state doesn't get set.
I suppose it's fine if we don't need loading state, but in that case just remove the unused SystemStatus.FETCH
action types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very clean way of creating a fetching thunk, but it doesn't follow lego-webapp convention.
It's sort of a mixture between "the convetion" and the readme fetching way. You're probably right about the loading states. Not sure what's the best way to do this is - do you have any input? I feel like you know our redux and call api implementation much better than I do
Also, I'm pretty sure the SystemStatus.FETCH won't work now, meaning loading state doesn't get set.
I suppose it's fine if we don't need loading state, but in that case just remove the unused SystemStatus.FETCH action types.
Removed 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fetching data from the readme of the repo hehe - couldn't find a better api
124860d
to
2659bc4
Compare
Description
Fetching data from the GitHub uptime repo hehe - couldn't find a better api
Result
Notice the pulse!
Screen.Recording.2024-12-15.at.12.43.51.mov
Testing
It works? Apparently one service has degraded performance 😩