Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and show upptime status in footer #5235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Dec 15, 2024

Description

Fetching data from the GitHub uptime repo hehe - couldn't find a better api

Result

Notice the pulse!

Current status (degraded) Operational
Screen.Recording.2024-12-15.at.12.43.51.mov
image

Testing

  • I have thoroughly tested my changes.

It works? Apparently one service has degraded performance 😩

@ivarnakken ivarnakken added future-is-now Pull requests that utilize cutting-edge technology or just a cool new feature review-needed Pull requests that need review new-feature Pull requests that introduce a new feature labels Dec 15, 2024
@ivarnakken ivarnakken requested a review from a team December 15, 2024 11:35
@ivarnakken ivarnakken self-assigned this Dec 15, 2024
Copy link

linear bot commented Dec 15, 2024

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 25, 2024 4:17pm

@ivarnakken ivarnakken changed the title Fix background color on flat buttons on hover Implement Implement and show upptime status in footer Dec 15, 2024
@ivarnakken ivarnakken changed the title Implement Implement and show upptime status in footer Implement and show upptime status in footer Dec 15, 2024
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Dec 15, 2024
Comment on lines +14 to +17
export const fetchSystemStatus = createAsyncThunk(
'status/fetch',
async (): Promise<SystemStatus> => {
const response = await fetch(
Copy link
Member

@eikhr eikhr Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clean way of creating a fetching thunk, but it doesn't follow lego-webapp convention. Also, I'm pretty sure the SystemStatus.FETCH won't work now, meaning loading state doesn't get set.

I suppose it's fine if we don't need loading state, but in that case just remove the unused SystemStatus.FETCH action types.

Copy link
Member Author

@ivarnakken ivarnakken Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clean way of creating a fetching thunk, but it doesn't follow lego-webapp convention.

It's sort of a mixture between "the convetion" and the readme fetching way. You're probably right about the loading states. Not sure what's the best way to do this is - do you have any input? I feel like you know our redux and call api implementation much better than I do

Also, I'm pretty sure the SystemStatus.FETCH won't work now, meaning loading state doesn't get set.

I suppose it's fine if we don't need loading state, but in that case just remove the unused SystemStatus.FETCH action types.

Removed 👍🏼

Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Fetching data from the readme of the repo hehe - couldn't find a better api
@ivarnakken ivarnakken force-pushed the ivarnakken/aba-1200-add-status-badge-in-footer branch from 124860d to 2659bc4 Compare December 25, 2024 16:17
@ivarnakken ivarnakken requested a review from eikhr December 26, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved future-is-now Pull requests that utilize cutting-edge technology or just a cool new feature new-feature Pull requests that introduce a new feature review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants