Improve the useful links on the public frontpage #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
Sort of a mixture of `dark` and `danger`.
ivarnakken
force-pushed
the
ivarnakken/aba-395-improve-nyttige-lenker-on-public
branch
from
39563a8 to
4e27143
Compare
ivarnakken
changed the title
LudvigHz
reviewed
Apr 16, 2023
They are all given images, which helps to seperate them. The description is now also easier to catch.
ivarnakken
force-pushed
the
ivarnakken/aba-395-improve-nyttige-lenker-on-public
branch
from
4e27143 to
91b0deb
Compare
LudvigHz
approved these changes
Apr 16, 2023
| href={item.link} | ||
| key={item.title} | ||
| rel="noreferrer" | ||
| target={item.isInternalLink ? '_self' : '_blank'} |
There was a problem hiding this comment.
Not a fan of this over using Link for the internal ones but I can let it slide.
ivarnakken
added
approved
ivarnakken
deleted the
ivarnakken/aba-395-improve-nyttige-lenker-on-public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a ghost button style
Sort of a mixture of
darkanddanger.Improve the useful links on the public frontpage
They are all given images, which helps to seperate them. The description
is now also easier to catch.
Result
Before
After
Screen.Recording.2023-04-16.at.17.46.04.mov
Testing
The
ghostbutton style does not affect other buttons.The useful link cards work on light and dark theme, and they wrap nicely on smaller viewports.
