Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore path for browser tests #9878

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Ignore path for browser tests #9878

merged 2 commits into from
Mar 2, 2023

Conversation

christian-bromann
Copy link
Member

Proposed changes

The current url for running the browser tests was /0-0/test.html?spec=... which becomes problematic if components deal with routes. To allow more flexibility this patch removes any requirement for a specific url to be set, it returns the text runner page for all routes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 2, 2023
@christian-bromann christian-bromann requested a review from a team March 2, 2023 19:21
@christian-bromann christian-bromann merged commit c85bc90 into main Mar 2, 2023
@christian-bromann christian-bromann deleted the cb-ignore-path branch March 2, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant