Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@wdio/cli: refactor #9394

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Conversation

SCG82
Copy link
Member

@SCG82 SCG82 commented Dec 13, 2022

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@SCG82 SCG82 marked this pull request as draft December 13, 2022 17:13
@SCG82 SCG82 marked this pull request as ready for review December 15, 2022 06:50
@christian-bromann
Copy link
Member

@SCG82 is this PR still relevant?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Dec 28, 2022
@SCG82
Copy link
Member Author

SCG82 commented Dec 28, 2022

@SCG82 is this PR still relevant?

Rebased. Yes it's relevant (replaces 'async-exit-hook' module declaration with @types/async-exit-hook, and splits run into a separate file)

👍

Hang on a sec, I'm working on it (moving @types to devDeps)

@SCG82
Copy link
Member Author

SCG82 commented Dec 28, 2022

@christian-bromann ready for review!

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@christian-bromann christian-bromann merged commit f4c2158 into webdriverio:main Dec 28, 2022
@SCG82 SCG82 deleted the refactor-wdio-cli branch December 28, 2022 12:44
@christian-bromann
Copy link
Member

@SCG82 it seems that this PR fails when running a production release (see https://github.com/webdriverio/webdriverio/actions/runs/3793821896/jobs/6451309605). I wonder if we should revert the change or install dev dependencies as part of the pipeline. Many of these files aren't used by users so it wouldn't hurt to keep them out of the deps list. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants