-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@wdio/cli: refactor #9394
@wdio/cli: refactor #9394
Conversation
2109e38
to
b73d824
Compare
@SCG82 is this PR still relevant? |
b73d824
to
517fcfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@christian-bromann ready for review! |
198a72c
to
631e7b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@SCG82 it seems that this PR fails when running a production release (see https://github.com/webdriverio/webdriverio/actions/runs/3793821896/jobs/6451309605). I wonder if we should revert the change or install dev dependencies as part of the pipeline. Many of these files aren't used by users so it wouldn't hurt to keep them out of the deps list. What do you think? |
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers