Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addValue and setValue #5937

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix addValue and setValue #5937

merged 1 commit into from
Oct 6, 2020

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Oct 6, 2020

Proposed changes

fix types after #5928

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@mgrybyk mgrybyk added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 6, 2020
christian-bromann
christian-bromann approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann
Copy link
Member

Good catch 👌

@christian-bromann christian-bromann merged commit 835ac19 into master Oct 6, 2020
@christian-bromann christian-bromann deleted the fix-add-set-value-types branch October 6, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrybyk @christian-bromann