Add context to before/after scenario hooks issue 5394 #5483

osmolyar · 2020-06-11T21:03:34Z

Proposed changes

Add context to before/after scenario hooks to resolve issue #5394

//: # Addressing issue #5394.

Types of changes Modeled on changes in https://github.com/webdriverio/webdriverio/pull/4545/files to add context parameter to hooks

Bugfix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

tests/helpers/cucumber-hooks.conf.js

christian-bromann · 2020-06-11T21:06:56Z

tests/helpers/cucumber-hooks.conf.js

@@ -7,9 +7,10 @@ exports.config = Object.assign({}, config, {
        await browser.pause(30)
        browser.Cucumber_Test = 0
    },
-    beforeScenario: () => {
+    beforeScenario: (world) => {


world should be the 5th parameter, no?

Yes; suspended work on this for now as it's not working. Erwin Heitzman suggested the hooks should be wrapped (similar to before/afterStep) but that also didn't seem to work.

Managed to link @wdio/cucumber-framework but it doesn't seem to be working at all. (In fact, can't even get context to console.log in before/afterStep where it is supposed to already be supported). Will close PR for now.

christian-bromann · 2020-06-11T21:07:04Z

tests/helpers/cucumber-hooks.conf.js

@@ -27,9 +28,15 @@ exports.config = Object.assign({}, config, {
        }
        browser.Cucumber_Test = 1
    },
-    afterScenario: () => {
+    afterScenario: (world) => {


packages/wdio-cucumber-framework/cucumber-framework.d.ts

Co-authored-by: Christian Bromann <github@christian-bromann.com>

osmolyar · 2020-06-12T15:23:24Z

Not working locally; closing for now

christian-bromann · 2020-06-12T15:35:26Z

Not working locally; closing for now

I recommend to use our smoke test to check if changes work. You can just try reproduce your desired scenario in our cucumber smoke project and run it while you are changing files.

osmolyar · 2020-06-12T16:48:47Z

Thanks for the tips. Am a little confused about how to use the cucumber smoke project because the thing that isn't 'working' is logging out the 'context' parameter in before/afterStep, before/afterScenario hood (before/afterStep even before the changes in this PR), and there is no config file with hooks in the smoke project. In any case the cucumberTestrunner tests are also failing but it's not clear why:

PS C:\webdriverio> npm run test:smoke cucumberTestrunner

webdriverio-monorepo@1.0.0 test:smoke C:\webdriverio
babel-node ./tests/smoke.runner.js "cucumberTestrunner"

Running smoke tests...

Execution of 2 spec files started at 2020-06-12T16:42:03.397Z

[BABEL] Note: The code generator has deoptimised the styling of C:\webdriverio\packages\wdio-webdriver-mock-service\node_modules\lodash\lodash.js as it exceeds the max of 500KB.
[0-1] FAILED
[0-0] FAILED

Spec Files: 0 passed, 2 failed, 2 total (100% completed) in 00:00:13

========== LOG OUPUT wdio-0-0.log

========== LOG OUPUT wdio-0-1.log

========== LOG OUPUT wdio.log
2020-06-12T16:42:09.930Z INFO @wdio/local-runner: Start worker 0-0 with arg: cucumberTestrunner
2020-06-12T16:42:10.063Z INFO @wdio/local-runner: Start worker 0-1 with arg: cucumberTestrunner
2020-06-12T16:42:16.810Z DEBUG @wdio/local-runner: Runner 0-1 finished with exit code 1
2020-06-12T16:42:16.829Z DEBUG @wdio/local-runner: Runner 0-0 finished with exit code 1
2020-06-12T16:42:16.961Z INFO @wdio/local-runner: Shutting down spawned worker
2020-06-12T16:42:17.225Z INFO @wdio/local-runner: Waiting for 0 to shut down gracefully

Error: Smoke test failed
at C:\webdriverio\tests\helpers\launch.js:39:11
at cucumberTestrunner (C:\webdriverio\tests\smoke.runner.js:101:7)
at runTests (C:\webdriverio\tests\smoke.runner.js:35:7)
at runTests (C:\webdriverio\tests\smoke.runner.js:35:7)
at C:\webdriverio\tests\smoke.runner.js:300:3
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webdriverio-monorepo@1.0.0 test:smoke: babel-node ./tests/smoke.runner.js "cucumberTestrunner"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the webdriverio-monorepo@1.0.0 test:smoke script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\osmolyar\AppData\Roaming\npm-cache_logs\2020-06-12T16_42_19_295Z-debug.log

christian-bromann · 2020-06-12T17:02:55Z

In any case the cucumberTestrunner tests are also failing but it's not clear why:

Is this with your change or without?

osmolyar · 2020-06-12T17:13:33Z

Both with and without changes.

christian-bromann · 2020-06-13T09:49:40Z

Can you try on a fresh checked out repository? These tests should pass (see CI pipeline).

osmolyar · 2020-06-15T13:29:51Z

Tried with a freshly cloned/checked out repository and the tests still fail. (Also had to install @wdio/local-runner separately after npm install and npm run setup-full to run smoke tests.)

osmolyar · 2020-06-22T17:21:15Z

@christian-bromann just fyi the cucumber smoke tests pass when run in a standalone command prompt, but not from the same directory within VSCode.

christian-bromann · 2020-06-22T17:34:03Z

when run in a standalone command prompt, but not from the same directory within VSCode.

Can you explain a bit further what you mean by that?

osmolyar · 2020-06-22T17:47:10Z

Sorry, the above comment is incorrect. The command "npm run test:smoke cucumberTestrunner" results in the same Failed result both in a command prompt and in VSCode's terminal window. It only says "All tests passed" when misspelled as "npm run test:smoke cucumberTestrunne" (presumably because then there are no tests to run). In any case the PR should be closed as the code changes don't work.

christian-bromann · 2020-06-22T17:55:44Z

@osmolyar I think the change still makes a lot of sense? Let's re-open and we jump on a 1:1 session through the WebdriverIO Office Hours?!

osmolyar · 2020-06-22T17:57:20Z

Ok- in a meeting for the next hour but otherwise anytime. Thanks

christian-bromann · 2020-06-22T17:57:58Z

but otherwise anytime

Please use the link to schedule a time. Thanks!

christian-bromann

👍 Thanks so much! That was a successful session.

Co-authored-by: Christian Bromann <github@christian-bromann.com>

osmolyar added 3 commits June 11, 2020 15:09

Added context parameter for before/afterScenario to relevant files

1403c30

Adding context to before/afterScenario in wdio.conf.tpl.js

0a8ae20

add space after comma to try to fix eslint error on publish branch

e845bac

christian-bromann reviewed Jun 11, 2020

View reviewed changes

Update tests/helpers/cucumber-hooks.conf.js

764957b

Co-authored-by: Christian Bromann <github@christian-bromann.com>

osmolyar closed this Jun 12, 2020

christian-bromann reopened this Jun 22, 2020

osmolyar closed this Jun 22, 2020

osmolyar reopened this Jun 22, 2020

Session with Christian to fix world parameter

b73a53a

christian-bromann approved these changes Jun 24, 2020

View reviewed changes

christian-bromann added PR: Bug Fix 🐛 PRs that contain bug fixes PR: Polish 💅 PRs that contain improvements on existing features and removed PR: Bug Fix 🐛 PRs that contain bug fixes labels Jun 24, 2020

christian-bromann merged commit 44869f4 into webdriverio:master Jun 24, 2020

osmolyar mentioned this pull request Jul 14, 2020

Remove extra space introduced by prior PR https://github.com/webdriverio/webdriverio/pull/5483 #5618

Merged

8 tasks

christian-bromann added a commit that referenced this pull request Jul 14, 2020

Remove extra space introduced by prior PR #5483 (#5618)

f0865cf

Co-authored-by: Christian Bromann <github@christian-bromann.com>

jvisco mentioned this pull request Nov 4, 2021

[🐛 Bug]: Cucumber afterScenario hook missing Cucumber's World object #7651

Closed

3 tasks

seaona mentioned this pull request Jun 7, 2023

[🐛 Bug]: Wdio hooks don't populate Cucumber's World on beforeScenario #10529

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add context to before/after scenario hooks issue 5394 #5483

Add context to before/after scenario hooks issue 5394 #5483

osmolyar commented Jun 11, 2020 •

edited

Loading

christian-bromann Jun 11, 2020

osmolyar Jun 11, 2020 •

edited

Loading

osmolyar Jun 12, 2020

christian-bromann Jun 11, 2020

osmolyar commented Jun 12, 2020

christian-bromann commented Jun 12, 2020

osmolyar commented Jun 12, 2020

christian-bromann commented Jun 12, 2020

osmolyar commented Jun 12, 2020

christian-bromann commented Jun 13, 2020

osmolyar commented Jun 15, 2020

osmolyar commented Jun 22, 2020

christian-bromann commented Jun 22, 2020

osmolyar commented Jun 22, 2020

christian-bromann commented Jun 22, 2020

osmolyar commented Jun 22, 2020

christian-bromann commented Jun 22, 2020

christian-bromann left a comment

Add context to before/after scenario hooks issue 5394 #5483

Add context to before/after scenario hooks issue 5394 #5483

Conversation

osmolyar commented Jun 11, 2020 • edited Loading

Proposed changes

Types of changes Modeled on changes in https://github.com/webdriverio/webdriverio/pull/4545/files to add context parameter to hooks

Checklist

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann Jun 11, 2020

Choose a reason for hiding this comment

osmolyar Jun 11, 2020 • edited Loading

Choose a reason for hiding this comment

osmolyar Jun 12, 2020

Choose a reason for hiding this comment

christian-bromann Jun 11, 2020

Choose a reason for hiding this comment

osmolyar commented Jun 12, 2020

christian-bromann commented Jun 12, 2020

osmolyar commented Jun 12, 2020

christian-bromann commented Jun 12, 2020

osmolyar commented Jun 12, 2020

christian-bromann commented Jun 13, 2020

osmolyar commented Jun 15, 2020

osmolyar commented Jun 22, 2020

christian-bromann commented Jun 22, 2020

osmolyar commented Jun 22, 2020

christian-bromann commented Jun 22, 2020

osmolyar commented Jun 22, 2020

christian-bromann commented Jun 22, 2020

christian-bromann left a comment

Choose a reason for hiding this comment

osmolyar commented Jun 11, 2020 •

edited

Loading

osmolyar Jun 11, 2020 •

edited

Loading