Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Network Primitives #5477

Merged
merged 23 commits into from
Jul 16, 2020
Merged

Implement Network Primitives #5477

merged 23 commits into from
Jul 16, 2020

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Jun 9, 2020 •
edited
Loading

Implementation of the proposal for network primitives.

@christian-bromann christian-bromann self-assigned this Jun 9, 2020
@christian-bromann christian-bromann requested a review from a team June 9, 2020 13:28
@mgrybyk
Copy link
Member

mgrybyk commented Jun 10, 2020

We can use network commands only with devtools automation protocol?

@christian-bromann
Copy link
Member Author

We can use network commands only with devtools automation protocol?

No. These will be available in all tests running WebdriverIO. I will also implement them to work on sessions running at Sauce Labs.

mgrybyk
mgrybyk requested changes Jun 10, 2020
View reviewed changes
Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a smoke / e2e test for network command?

packages/webdriverio/src/utils/getNetworkObject.js Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Member Author

Can you please add a smoke / e2e test for network command?

This PR doesn't contain any command that could be tested with a smoke test. I will leave this to the subsequent PRs.

@christian-bromann christian-bromann force-pushed the cb-network-scope branch 2 times, most recently from 8232bb9 to fa49375 Compare June 25, 2020 09:08
mgrybyk
mgrybyk approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added DON'T MERGE Pull Requests that are blocked on something and should not be merged PR: New Feature 🚀 PRs that contain new features labels Jun 25, 2020
@christian-bromann
Copy link
Member Author

Please don't merge this PR. I will merge the rest of the network features into here to ship it as a whole.

@christian-bromann christian-bromann added needs-review These Pull Requests require review from project members and removed needs-review These Pull Requests require review from project members DON'T MERGE Pull Requests that are blocked on something and should not be merged labels Jul 9, 2020
@webdriverio webdriverio deleted a comment from jsf-clabot Jul 15, 2020
@christian-bromann christian-bromann changed the title Implement Network Scope Implement Network Primitives Jul 15, 2020
@christian-bromann christian-bromann merged commit b26677b into master Jul 16, 2020
@christian-bromann christian-bromann deleted the cb-network-scope branch July 16, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caoxu2000 caoxu2000 caoxu2000 approved these changes

@mgrybyk mgrybyk mgrybyk approved these changes

Assignees

@christian-bromann christian-bromann

Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christian-bromann @mgrybyk @caoxu2000