Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to Tidelift subscription #5375

Merged
merged 3 commits into from
May 8, 2020
Merged

Add docs to Tidelift subscription #5375

merged 3 commits into from
May 8, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

As we recently joined Tidelift we want to ensure that users know about it. This PR adds a page to the docs describing what this means. It is part of Tidelifts project onboarding process.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 7, 2020
@christian-bromann christian-bromann requested a review from a team May 7, 2020 22:46
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks

docs/Enterprise.md Outdated Show resolved Hide resolved
docs/Enterprise.md Show resolved Hide resolved
docs/Enterprise.md Show resolved Hide resolved
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@erwinheitzman
Copy link
Member

Should we merge this ignoring the error in the CI?

@christian-bromann
Copy link
Member Author

Should we merge this ignoring the error in the CI?

Just added a tweak to the unit test that was causing this flake.

@christian-bromann christian-bromann merged commit b3ce419 into master May 8, 2020
@christian-bromann christian-bromann deleted the cb-tidelift branch May 8, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants