Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wdio-lambdatest-service: Updated docs for New service Lambdatest #5057 #5097

Merged
merged 2 commits into from
Mar 13, 2020
Merged

wdio-lambdatest-service: Updated docs for New service Lambdatest #5057 #5097

merged 2 commits into from
Mar 13, 2020

Conversation

kanhaiya15
Copy link

Proposed changes

Docs changes for service lambdatest

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

christian-bromann
christian-bromann requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments:

README.md Outdated Show resolved Hide resolved
scripts/docs-generation/3rd-party/services.json Outdated Show resolved Hide resolved
@christian-bromann christian-bromann added backport-requested PRs with this label are considered to be applied to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation labels Mar 13, 2020
christian-bromann
christian-bromann approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 63e988c into webdriverio:master Mar 13, 2020
@christian-bromann christian-bromann added backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels Mar 14, 2020
christian-bromann pushed a commit that referenced this pull request Mar 14, 2020
@christian-bromann
wdio-lambdatest-service: Updated docs for New service Lambdates… (#5097)
41e826e 
* wdio-lambdatest-service: Updated docs for New service Lambdatest #5057

* wdio-lambdatest-service: Fixed typo
@kanhaiya15
Copy link
Author

Thanks @christian-bromann

@christian-bromann christian-bromann mentioned this pull request Jul 19, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanhaiya15 @christian-bromann