Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for touchPerform #5004

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Conversation

christian-bromann
Copy link
Member

Proposed changes

Added an example for touchPerform.

Closes #4968

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added PR: Docs 📝 PRs that contain changes to the documentation backport-requested PRs with this label are considered to be applied to the last maintained version labels Feb 10, 2020
@christian-bromann christian-bromann requested a review from a team February 10, 2020 09:13
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #5004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5004   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         210      210           
  Lines        5509     5509           
  Branches     1180     1180           
=======================================
  Hits         5477     5477           
  Misses         29       29           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6913f...458c185. Read the comment docs.

@christian-bromann christian-bromann force-pushed the cb-add-touchPerform-example branch from 45c9d73 to 458c185 Compare February 11, 2020 11:48
@christian-bromann
Copy link
Member Author

@erwinheitzman added missing vars, please let me know if anything else is missing

Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit 3d123ae into master Feb 12, 2020
@christian-bromann christian-bromann deleted the cb-add-touchPerform-example branch February 12, 2020 19:00
@christian-bromann christian-bromann added backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels Feb 14, 2020
christian-bromann added a commit that referenced this pull request Feb 14, 2020
* Add example for touchPerform

* fix json

* add missing vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document touchPerform with my example
2 participants