Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update action.ts example #10755

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Update action.ts example #10755

merged 1 commit into from
Jul 18, 2023

Conversation

MotorMike
Copy link
Contributor

add missing ' from the example

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@MotorMike
Update action.ts example
df569db 
add missing ' from example
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MotorMike / name: Mike Nicholls (df569db)

@christian-bromann
Copy link
Member

Thanks @MotorMike for the PR 👏 mind signing the CLA?

@MotorMike
Copy link
Contributor Author

Sure thing @christian-bromann ✅ 😄

christian-bromann
christian-bromann approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a ton 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jul 18, 2023
@christian-bromann christian-bromann merged commit ae62485 into webdriverio:main Jul 18, 2023
2 checks passed
@christian-bromann
Copy link
Member

We will release a new version of the docs with the next release. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MotorMike @christian-bromann