(webdriver): re-export command #10731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
reviewed
Jul 14, 2023
| } | ||
| } | ||
|
|
||
| module.exports = WebDriver | ||
| exports.command = command |
There was a problem hiding this comment.
Suggested change
| exports.command = command | |
| module.exports.command = command |
There was a problem hiding this comment.
module.exports = WebDriver which has command as static property, so it should be the same, right?
There was a problem hiding this comment.
the test seem to pass:
const WebDriver = require('../../packages/webdriver')
const command = require('../../packages/webdriver').command
assert.equal(typeof WebDriver.command, 'function')
assert.equal(typeof command, 'function')There was a problem hiding this comment.
oh I didn't see the refactor above, this was a suggestion based on the initial commit. let me try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make what is documented here work when using CJS.
Types of changes
Checklist
Further comments
Thanks @jlipps for reporting.
Reviewers: @webdriverio/project-committers