sites.google.com - Unable to select website pages by clicking the page title text

[webcompat-bot]

URL: https://sites.google.com/

Browser / Version: Firefox 89.0
Operating System: Windows 10
Tested Another Browser: Yes Chrome

Problem type: Site is not usable
Description: Buttons or links not working
Steps to Reproduce:
Basically two things when I try to biuld a page in Google sites:

• Doesn't work the section Pages o the right. When I try to click a subpage doesn't go anywhere.
• I uploaded pictures and sometimes the pictures disappeared from the template and I need to reload the template again .(in my screenshoot the problem is when I click "insights", "Search bar", etc)

I can't send you my template, basically because is personal, but I assuma that you will have this error with any template you build in Google Sites.

View the screenshot

Browser Configuration

• gfx.webrender.all: false
• gfx.webrender.blob-images: true
• gfx.webrender.enabled: false
• image.mem.shared: true
• buildID: 20210502185943
• channel: beta
• hasTouchScreen: false
• mixed active content blocked: false
• mixed passive content blocked: false
• tracking content blocked: false

View console log messages

From webcompat.com with ❤️

[softvision-oana-arbuzov]

Thanks for the report, I've signed into my test account and created a site.
URL: https://sites.google.com/d/1arZNKcl0lTCk-yaX3qLV9rwRapMazeA5/p/1iZVR1_3nvaD5k9odB9qyii3w_ZtERGjH/edit

I was to reproduce the issue related to the selection of the pages on the right side. It seem that if I click the text the page is not selected, but if I click the page icon then pages is selected and changed.

Note:

1. The issue is not reproducible on Chrome.

Related to second issue, for me images remains displayed.

Tested with:
Browser / Version: Firefox Nightly 90.0a1 (2021-05-11)
Operating System: Windows 10 Pro

Moving to Needsdiagnosis for further investigation.

[karlcow]

On the icon indeed, a click event is received

11:51:29.417
click { target: path
, buttons: 0, clientX: 1026, clientY: 236, layerX: 32, layerY: 22 }
m=e,aa:1694:46
11:51:29.420
click { target: path
, buttons: 0, clientX: 1026, clientY: 236, layerX: 32, layerY: 22 }
rs=AA2YrTv8hYdW91t8l5nZ9OM47lsQ8quCgQ:59:37
11:51:29.423
click { target: path
, buttons: 0, clientX: 1026, clientY: 236, layerX: 32, layerY: 22 }
m=e,aa:488:39
11:51:29.426
click { target: path
, buttons: 0, clientX: 1026, clientY: 236, layerX: 32, layerY: 22 }
m=e,aa:1700:221

but on the text no event is received at all.

[wisniewskit]

After some sleuthing, it looks like the code that handles the events is in this function:

    HJa = function (a, b) {
      return function f(d, e) {
        e = void 0 === e ? !0 : e;
        var g = b;
        'click' == g && (lJa && d.metaKey || !lJa && d.ctrlKey || 2 == d.which || null == d.which && 4 == d.button || d.shiftKey) ? g = 'clickmod' : uJa(d) && (g = 'clickkey');
        var k = d.srcElement || d.target;
// snip
          'maybe_click' == N && X.click ? (n = N, N = 'click') : 'clickkey' == N ? N = 'click' : 'click' != N || X.click || (N = 'clickonly');
          n = mr._cfc && X.click ? mr._cfc(F, R, X, N, n) : {
            eventType: n ?
            n : N,
            action: X[N] || '',
            event: null,
            ignore: !1
          };
// snip

But indeed a click event does not get into this function in Firefox when clicking on the labels, only when clicking on the icon (an SVG path). But Chrome does receive the click on labels.

So I decided to jump down the JS rabbit-hole for entirely too long before I realized that this is the element we're clicking on for the labels:

<input type="text" disabled="" class="whsOnd zHQkBf" jsname="YPqjbf" autocomplete="off" tabindex="0" aria-label="Page title" maxlength="75" value="Home" dir="ltr" data-initial-value="Home">

Notice the disabled? Yeah. Removing it will fix the problem. So this is another case of https://bugzilla.mozilla.org/show_bug.cgi?id=1653882 .

[wisniewskit]

I suspect that we can do a site intervention here until Google figures this out, but it's hard to know how reliable a fix would be given the minified CSS class names are probably sensitive to any minor page updates, and I'd imagine the aria-label might be internationalized. But it might be worth our time to remove all disabled attributes from inputs, given that they seem to handle the clicks using a listener added to the HTML element anyway (I'm not sure why they disable it; to prevent text-selection, maybe?)

[nt1m]

@wisniewskit Can anyone re-test if this is fixed?

[hsinyi]

@wisniewskit Can anyone re-test if this is fixed?

I just verified this issue with the url link mentioned in this comment. The issue is fixed for me, Firefox Nightly 124, Win11.

[wisniewskit]

Thanks, let's close this as fixed.