-
Notifications
You must be signed in to change notification settings - Fork 202
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #123 from webasyst/dev
fix
- Loading branch information
Showing
2 changed files
with
1 addition
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
059db3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Свойство
$info
у насprotected
, поэтому какая-то возможность доступа к полям описания плагина быть все-таки должна, IMHO.getInfo()
можно было бы наоборот расширить, чтобы не только весь массив сразу получать, а по примеруgetSettings()
получить какой-то определенный параметр.Или планируется просто геттер?
059db3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public method getInfo как оказалось используется в нескольких плагинах сторонних разработчиков
в итоге получали fatal error, т.к. в родителе метод protected
Так что пока удалили, скорее всего добавил getPluginInfo() или что-то типа того по аналогии с getSettings