chore: remove obsolete core module #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavyaroslav
previously approved these changes
Jan 27, 2023
JeneaVranceanu
previously approved these changes
Feb 1, 2023
|
@janndriessen Some kind of conflict with deleted ABIElements.swift is present. |
janndriessen
force-pushed
the
task/remove-obsolete-core-module
branch
from
00c91be to
c5f82ff
Compare
janndriessen
dismissed stale reviews from JeneaVranceanu and yaroslavyaroslav
via
28790b8
janndriessen
force-pushed
the
task/remove-obsolete-core-module
branch
from
28790b8 to
08f3d00
Compare
JeneaVranceanu
approved these changes
Feb 2, 2023
yaroslavyaroslav
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes the obsolete
Coremodule which had one file left from before (ABIElements.swift).Note⚠️ that there was a large difference between this file
ABIElementsand theABIElementsnow present inWeb3Core/EthereumABI. Just checked the one inCoreseemed to have been last changed mid November (https://github.com/web3swift-team/web3swift/commits/develop/Sources/Core/EthereumABI/ABIElements.swift) while the one inWeb3Corebeg/mid December.By submitting this pull request, you are confirming the following:
developbranch.