Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENS properties mutability #723

Merged
merged 1 commit into from
Jan 10, 2023
Merged

ENS properties mutability #723

merged 1 commit into from
Jan 10, 2023

Conversation

albertopeam
Copy link
Contributor

change properties visibility to avoid mutations without using the setters

Summary of Changes

Related to #721.

Test Data or Screenshots

Test passed successfully

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@albertopeam albertopeam changed the title ENS properties visibility ENS properties mutability Jan 8, 2023
@JeneaVranceanu JeneaVranceanu merged commit bae0e34 into web3swift-team:develop Jan 10, 2023
@albertopeam albertopeam deleted the feature/ens-public-vars branch January 11, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

@janndriessen janndriessen janndriessen approved these changes

@yaroslavyaroslav yaroslavyaroslav Awaiting requested review from yaroslavyaroslav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertopeam @janndriessen @JeneaVranceanu