Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 4 vulnerabilities #7244

Open
wants to merge 3 commits into
base: 4.x
Choose a base branch
from

Conversation

Muhammad-Altabba
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • tools/eslint-config-base-web3/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Uncontrolled resource consumption
SNYK-JS-BRACES-6838727
  696  
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
  696  
medium severity Prototype Pollution
SNYK-JS-JSON5-3182856
  641  
high severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728
  589  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Uncontrolled resource consumption
🦉 Prototype Pollution

Copy link

github-actions bot commented Sep 6, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.62 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 620.22 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 735b7f1 Previous: b86d8ca Ratio
processingTx 20105 ops/sec (±7.84%) 22440 ops/sec (±7.06%) 1.12
processingContractDeploy 38463 ops/sec (±6.33%) 38564 ops/sec (±7.90%) 1.00
processingContractMethodSend 15115 ops/sec (±9.45%) 16696 ops/sec (±7.81%) 1.10
processingContractMethodCall 27825 ops/sec (±6.46%) 27650 ops/sec (±7.82%) 0.99
abiEncode 42595 ops/sec (±7.00%) 44651 ops/sec (±6.88%) 1.05
abiDecode 29583 ops/sec (±7.65%) 30424 ops/sec (±7.61%) 1.03
sign 1488 ops/sec (±3.09%) 1574 ops/sec (±0.58%) 1.06
verify 363 ops/sec (±0.41%) 365 ops/sec (±2.65%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (b86d8ca) to head (a0bc572).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7244   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         216      216           
  Lines        8454     8454           
  Branches     2335     2335           
=======================================
  Hits         7984     7984           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint test should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants