Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1x deps update #6491

Merged
merged 3 commits into from
Oct 11, 2023
Merged

1x deps update #6491

merged 3 commits into from
Oct 11, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Oct 9, 2023

Description

1x deps update

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6456991070

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.766%

Totals Coverage Status
Change from base Build 6379451136: 0.0%
Covered Lines: 3488
Relevant Lines: 4516

💛 - Coveralls

@jdevcs jdevcs merged commit dbd96ae into 1.x Oct 11, 2023
10 of 11 checks passed
@jdevcs jdevcs deleted the junaid/1xdepsupdateoct branch October 11, 2023 13:46
@jdevcs jdevcs mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants