Transaction `input` and `data` refactors #6294

spacesailor24 · 2023-07-19T20:50:23Z

…, don't autofill unless both or nullish

github-actions · 2023-07-19T20:59:21Z

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset	Old size	New size	Diff	Diff %
Total	652 KB	652 KB	214 bytes	0.03%

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	Old size	New size	Diff	Diff %
web3.min.js	635 KB	635 KB	214 bytes	0.03%
../lib/commonjs/index.d.ts	8.56 KB	8.56 KB	0	0.00%
../lib/commonjs/accounts.d.ts	3.67 KB	3.67 KB	0	0.00%
../lib/commonjs/types.d.ts	2.45 KB	2.45 KB	0	0.00%
../lib/commonjs/web3.d.ts	1.14 KB	1.14 KB	0	0.00%
../lib/commonjs/abi.d.ts	1000 bytes	1000 bytes	0	0.00%
../lib/commonjs/eth.exports.d.ts	280 bytes	280 bytes	0	0.00%
../lib/commonjs/providers.exports.d.ts	148 bytes	148 bytes	0	0.00%
../lib/commonjs/version.d.ts	60 bytes	60 bytes	0	0.00%

codecov · 2023-07-19T21:06:00Z

Codecov Report

Merging #6294 (d82de1a) into 4.x (0ee9bb4) will decrease coverage by 0.03%.
The diff coverage is 90.47%.

Additional details and impacted files

@@            Coverage Diff             @@
##              4.x    #6294      +/-   ##
==========================================
- Coverage   88.89%   88.86%   -0.03%     
==========================================
  Files         199      199              
  Lines        7706     7707       +1     
  Branches     2115     2120       +5     
==========================================
- Hits         6850     6849       -1     
- Misses        856      858       +2

Flag	Coverage Δ
UnitTests	`88.86% <90.47%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
web3	`∅ <ø> (∅)`
web3-core	`∅ <ø> (∅)`
web3-errors	`∅ <ø> (∅)`
web3-eth	`∅ <ø> (∅)`
web3-eth-abi	`∅ <ø> (∅)`
web3-eth-accounts	`∅ <ø> (∅)`
web3-eth-contract	`∅ <ø> (∅)`
web3-eth-ens	`∅ <ø> (∅)`
web3-eth-iban	`∅ <ø> (∅)`
web3-eth-personal	`∅ <ø> (∅)`
web3-net	`∅ <ø> (∅)`
web3-providers-http	`∅ <ø> (∅)`
web3-providers-ipc	`∅ <ø> (∅)`
web3-providers-ws	`∅ <ø> (∅)`
web3-rpc-methods	`∅ <ø> (∅)`
web3-utils	`∅ <ø> (∅)`
web3-validator	`∅ <ø> (∅)`

cloudflare-workers-and-pages · 2023-07-19T21:12:18Z

Deploying with Cloudflare Pages

Latest commit:	`d82de1a`
Status:	✅ Deploy successful!
Preview URL:	https://3e9f707b.web3-js-docs.pages.dev
Branch Preview URL:	https://wyatt-4-x-6183-input-data-re.web3-js-docs.pages.dev

View logs

…ta properties

spacesailor24 · 2023-07-20T01:41:55Z

packages/web3-eth/src/utils/prepare_transaction_for_signing.ts

@@ -42,7 +42,7 @@ const getEthereumjsTxDataFromTransaction = (
 	gasLimit: transaction.gasLimit ?? transaction.gas,
 	to: transaction.to,
 	value: transaction.value,
-	data: transaction.input,
+	data: transaction.data ?? transaction.input,


The property name is still data because that's what TransactionFactory.fromTxData is expecting

spacesailor24 · 2023-07-20T01:44:19Z

packages/web3-types/src/eth_types.ts

+	input?: Bytes;
+	data?: Bytes;


This is a breaking change for eth_types, but input won't be apart of this object if the user uses data

luu-alex · 2023-07-20T15:03:00Z

LGTM needs a changelog update

…ctionSchema optional with transactoinInfoSchema the default value

…paring equality for TransactionDataAndInputError check

spacesailor24 · 2023-07-28T01:16:25Z

packages/web3-eth/src/utils/format_transaction.ts

-		transactionSchema,
+	options: {
+		transactionSchema?: ValidationSchemaInput | typeof transactionSchema;
+		fillInputAndData?: boolean;


A new parameter, fillInputAndData, was added to the options argument for formatTransaction. This method is used for formatting both user submitted and RPC response transaction objects. So, we need a flag to determine whether to leave the transaction object as given, or fill in the input or data properties if they weren't present. The fillInputAndData option is set in rpc_method_wrappers.ts for relevant methods

This, and things similar, needs to be in the documentation.

spacesailor24 · 2023-08-02T19:55:21Z

@Muhammad-Altabba Need your re-review

Muhammad-Altabba

Good job!
All good now I think.
However, the documentation needs to be updated accordingly.

Muhammad-Altabba · 2023-08-03T14:32:16Z

packages/web3-eth/src/utils/format_transaction.ts

-		transactionSchema,
+	options: {
+		transactionSchema?: ValidationSchemaInput | typeof transactionSchema;
+		fillInputAndData?: boolean;


This, and things similar, needs to be in the documentation.

spacesailor24 added 2 commits July 19, 2023 10:47

Remove extra formatting check for input and data for transactionSchema

5c65103

Update transaciton builder to only use input or data provided by user…

7a5b5ca

…, don't autofill unless both or nullish

spacesailor24 added the 4.x 4.0 related label Jul 19, 2023

spacesailor24 self-assigned this Jul 19, 2023

github-actions bot deployed to web3-js-docs (Preview) July 19, 2023 21:11 View deployment

spacesailor24 added 2 commits July 19, 2023 14:20

Add check for transaction.data for getEthereumjsTxDataFromTransaction

7412abe

Update PopulatedUnsignedBaseTransaction to have optional input and da…

9d56a31

…ta properties

github-actions bot deployed to web3-js-docs (Preview) July 20, 2023 00:57 View deployment

Update sign_transaction test

ee074e6

github-actions bot deployed to web3-js-docs (Preview) July 20, 2023 01:40 View deployment

spacesailor24 commented Jul 20, 2023

View reviewed changes

spacesailor24 marked this pull request as ready for review July 20, 2023 01:45

spacesailor24 requested review from avkos, jdevcs, luu-alex and Muhammad-Altabba as code owners July 20, 2023 01:45

spacesailor24 mentioned this pull request Jul 20, 2023

input parameter added when calling estimateGas for a specific contract call in v4.0.1 #6183

Closed

Update CHANGELOGs

2f03bb7

github-actions bot deployed to web3-js-docs (Preview) July 20, 2023 21:19 View deployment

luu-alex approved these changes Jul 20, 2023

View reviewed changes

Merge branch '4.x' into wyatt/4.x/6183-input-data-refactor

f32feb6

github-actions bot deployed to web3-js-docs (Preview) July 21, 2023 00:11 View deployment

jdevcs approved these changes Jul 21, 2023

View reviewed changes

luu-alex mentioned this pull request Jul 23, 2023

Duplicate "Data" and "Input" Fields in eth_call #6301

Closed

0xJchen mentioned this pull request Jul 23, 2023

Error when sending duplicate "Data" and "Input" Fields paradigmxyz/reth#3875

Closed

1 task

avkos self-requested a review July 24, 2023 16:29

Muhammad-Altabba self-requested a review July 25, 2023 16:29

avkos approved these changes Jul 25, 2023

View reviewed changes

spacesailor24 added 3 commits July 27, 2023 12:20

Merge branch '4.x' into wyatt/4.x/6183-input-data-refactor

a5b195d

Add fillInputAndData option to formatTransaction. Make options.transa…

24ae148

…ctionSchema optional with transactoinInfoSchema the default value

Update tests

19023ea

github-actions bot deployed to web3-js-docs (Preview) July 27, 2023 23:30 View deployment

spacesailor24 added 3 commits July 27, 2023 13:41

Update CHANGELOGs

1b0b30d

Convert formattedTransaction. input and data to hex string before com…

df836d5

…paring equality for TransactionDataAndInputError check

Update test fixtures

e75e379

github-actions bot deployed to web3-js-docs (Preview) July 28, 2023 00:00 View deployment

Add options.fillInputAndData to decodeSignedTransaction

a4ca37c

github-actions bot deployed to web3-js-docs (Preview) July 28, 2023 00:28 View deployment

Update sign_transaction fixture data

d82de1a

github-actions bot deployed to web3-js-docs (Preview) July 28, 2023 01:10 View deployment

spacesailor24 commented Jul 28, 2023

View reviewed changes

spacesailor24 removed their assignment Jul 28, 2023

spacesailor24 requested review from avkos, luu-alex and jdevcs July 28, 2023 01:41

avkos approved these changes Jul 31, 2023

View reviewed changes

jdevcs approved these changes Aug 1, 2023

View reviewed changes

Muhammad-Altabba approved these changes Aug 3, 2023

View reviewed changes

Muhammad-Altabba mentioned this pull request Aug 3, 2023

Update documentation according to #6294 #6330

Open

jdevcs merged commit 51d087e into 4.x Aug 3, 2023
67 checks passed

jdevcs deleted the wyatt/4.x/6183-input-data-refactor branch August 3, 2023 14:57

This was referenced Aug 3, 2023

Release 4.0.4 RC #6331

Closed

Release/4.1.0 #6342

Merged

luu-alex mentioned this pull request Aug 29, 2023

6355 - allow data to be used in contract methods. #6377

Merged

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction `input` and `data` refactors #6294

Transaction `input` and `data` refactors #6294

spacesailor24 commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

codecov bot commented Jul 19, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Jul 19, 2023 •

edited

Loading

spacesailor24 Jul 20, 2023

spacesailor24 Jul 20, 2023

luu-alex commented Jul 20, 2023

spacesailor24 Jul 28, 2023 •

edited

Loading

Muhammad-Altabba Aug 3, 2023

spacesailor24 commented Aug 2, 2023

Muhammad-Altabba left a comment

Muhammad-Altabba Aug 3, 2023

Transaction input and data refactors #6294

Transaction input and data refactors #6294

Conversation

spacesailor24 commented Jul 19, 2023 • edited Loading

github-actions bot commented Jul 19, 2023 • edited Loading

Bundle Stats

codecov bot commented Jul 19, 2023 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Jul 19, 2023 • edited Loading

Deploying with Cloudflare Pages

spacesailor24 Jul 20, 2023

Choose a reason for hiding this comment

spacesailor24 Jul 20, 2023

Choose a reason for hiding this comment

luu-alex commented Jul 20, 2023

spacesailor24 Jul 28, 2023 • edited Loading

Choose a reason for hiding this comment

Muhammad-Altabba Aug 3, 2023

Choose a reason for hiding this comment

spacesailor24 commented Aug 2, 2023

Muhammad-Altabba left a comment

Choose a reason for hiding this comment

Muhammad-Altabba Aug 3, 2023

Choose a reason for hiding this comment

Transaction `input` and `data` refactors #6294

Transaction `input` and `data` refactors #6294

spacesailor24 commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

codecov bot commented Jul 19, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Jul 19, 2023 •

edited

Loading

spacesailor24 Jul 28, 2023 •

edited

Loading