Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse nested error for Smartcontract errors #6045

Merged

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Apr 26, 2023

Description

Fixes #6007

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 708 KB 708 KB 428 bytes 0.06%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 691 KB 691 KB 428 bytes 0.06%
../lib/commonjs/index.d.ts 8.43 KB 8.43 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.37 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 808 bytes 808 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 561d67a
Status: ✅  Deploy successful!
Preview URL: https://207aed9b.web3-js-docs.pages.dev
Branch Preview URL: https://6007-parse-nested-error-for.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #6045 (561d67a) into 4.x (d4b4b8b) will increase coverage by 0.01%.
The diff coverage is 95.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6045      +/-   ##
==========================================
+ Coverage   85.98%   86.00%   +0.01%     
==========================================
  Files         203      203              
  Lines        7522     7536      +14     
  Branches     2022     2030       +8     
==========================================
+ Hits         6468     6481      +13     
- Misses       1054     1055       +1     
Flag Coverage Δ
UnitTests 86.00% <95.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review April 27, 2023 14:41
@Muhammad-Altabba Muhammad-Altabba marked this pull request as draft April 27, 2023 14:43
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, codecov patch diff is 60% so some more testing is required for covering new lines. Thanks @Muhammad-Altabba

@Muhammad-Altabba
Copy link
Contributor Author

LGTM, codecov patch diff is 60% so some more testing is required for covering new lines. Thanks @Muhammad-Altabba

Sorry, I marked the PR as ready after I pushed the tests but before CodeCov updated the stats. It is updated now and the coverage for this MR is 85.00%.

@Muhammad-Altabba Muhammad-Altabba merged commit 667668a into 4.x May 5, 2023
@Muhammad-Altabba Muhammad-Altabba deleted the 6007-parse-nested-error-for-smartcontract-errors branch May 5, 2023 13:57
@jdevcs jdevcs mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: "n.data.substring is not a function", when setting web.eth.handleRevert = true
5 participants