Remove erroneous set provider code for Contract constructor

CHANGELOG.md

@@ -932,3 +932,7 @@ should use 4.0.1-alpha.0 for testing.
 #### web3-eth-accounts
 
 -   These types were moved from `web3-eth-accounts` to `web3-types` package: Cipher, CipherOptions, ScryptParams, PBKDF2SHA256Params, KeyStore (#5581 )
+
+#### web3-eth-contract
+
+-   Erroneous set `provider` logic in Contract constructor (#5669)

packages/web3-eth-contract/CHANGELOG.md

@@ -190,3 +190,7 @@ const transactionHash = receipt.transactionHash;
 
 -   Emit past contract events based on `fromBlock` when passed to `contract.events.someEventName` (#5201)
 -   Use different types for `ContractOptions` -> `jsonInterface` setter and getter (#5474)
+
+### Removed
+
+-   Erroneous set `provider` logic in Contract constructor (#5669)

packages/web3-eth-contract/src/contract.ts

@@ -357,17 +357,15 @@ export class Contract<Abi extends ContractAbi>
 				? optionsOrContextOrReturnFormat
 				: contextOrReturnFormat),
 			provider:
-				typeof addressOrOptionsOrContext !== 'string'
-					? addressOrOptionsOrContext?.provider ??
-					  // eslint-disable-next-line no-nested-ternary
-					  (typeof optionsOrContextOrReturnFormat === 'object' &&
-					  'provider' in optionsOrContextOrReturnFormat
-							? optionsOrContextOrReturnFormat.provider
-							: typeof contextOrReturnFormat === 'object' &&
-							  'provider' in contextOrReturnFormat
-							? contextOrReturnFormat?.provider
-							: Contract.givenProvider)
-					: undefined,
+				(addressOrOptionsOrContext as Web3ContractContext)?.provider ??
+				// eslint-disable-next-line no-nested-ternary
+				(typeof optionsOrContextOrReturnFormat === 'object' &&
+				'provider' in optionsOrContextOrReturnFormat
+					? optionsOrContextOrReturnFormat.provider
+					: typeof contextOrReturnFormat === 'object' &&
+					  'provider' in contextOrReturnFormat
+					? contextOrReturnFormat?.provider
+					: Contract.givenProvider),
 			registeredSubscriptions: contractSubscriptions,
 		});
 

packages/web3-eth-contract/test/unit/contract.test.ts

@@ -72,6 +72,18 @@ describe('Contract', () => {
 
 			expect(contract).toBeInstanceOf(Contract);
 		});
+
+		it('should set the provider upon instantiation', () => {
+			const provider = 'http://127.0.0.1:8545';
+			const contract = new Contract([], '', {
+				provider,
+			});
+
+			expect(contract.provider).toEqual({
+				clientUrl: provider,
+				httpProviderOptions: undefined,
+			});
+		});
 	});
 
 	describe('Contract functions and defaults', () => {