Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Uuid for response id #5628

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #5373

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@Muhammad-Altabba Muhammad-Altabba marked this pull request as draft November 17, 2022 14:12
@Muhammad-Altabba Muhammad-Altabba changed the base branch from 1.x to 4.x November 17, 2022 14:12
@render
Copy link

render bot commented Nov 17, 2022

@Muhammad-Altabba Muhammad-Altabba changed the title [DRAFT] Use Uuid for response id Use Uuid for response id Nov 18, 2022
@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review November 18, 2022 07:20
@Muhammad-Altabba Muhammad-Altabba requested review from luu-alex, jdevcs, avkos, nikoulai and spacesailor24 and removed request for luu-alex and jdevcs November 18, 2022 07:20
@nikoulai
Copy link
Contributor

nikoulai commented Nov 18, 2022

Does this particular change, make jest run for more time?

@Muhammad-Altabba
Copy link
Contributor Author

Does this particular change, make jest run for more time?

Sorry for the confusion. Forget about that. I just reverted back to the old value of the timeout. As it actually did not matter.
And I already created another issue for the timeout error at pipeline: #5634

@Muhammad-Altabba Muhammad-Altabba merged commit 0727f26 into 4.x Nov 18, 2022
@Muhammad-Altabba Muhammad-Altabba deleted the fix/5373/use-uuid-for-responseid branch November 18, 2022 20:34
@mconnelly8 mconnelly8 mentioned this pull request Oct 18, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responses get mixed up due to conflicting payload IDs (v 4.x)
4 participants