Clarify that 0x prefix is needed for imported private keys #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run an issue that `web3.eth.accounts.privateKeyToAccount` private key format was behaving differently from other Ethereum packages * truffle-hd-wallet * ethereumjs-wallet This may lead to a problem that users are freaking out and think they lost their account when dealing with raw private keys. web3.js generated different accounts from the other packages because private key was handled differently. This was because of the disagreement if hexadecimal private keys should be prefixed with `0x` or not. I clarified this in the documentation and also added a pointer about creating a HD wallet.
cgewecke
added
1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purely documentation update.
I run an issue that
web3.eth.accounts.privateKeyToAccountprivate key format was behaving differently from other Ethereum packagestruffle-hd-wallet
ethereumjs-wallet
This may lead to a problem that users are freaking out and think they lost their account when dealing with raw private keys.
web3.js generated different accounts from the other packages because private key was handled differently. This was because of the disagreement if hexadecimal private keys should be prefixed with
0xor not.I clarified this in the documentation and also added a pointer about creating a HD wallet.
Type of change
Checklist: