Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swarm-js to ^0.1.40 #3403

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Upgrade swarm-js to ^0.1.40 #3403

merged 3 commits into from
Mar 20, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Mar 4, 2020

Description

Silences npm audit warning reported in #3399. One of swarm-js's dependencies was flagged as high vuln. Resolved by swarm-js 36

NB: floating this dep now because that's been recommended in #3186 and @evertonfraga is a maintainer.

Fixes #3399

Type of change

  • Dependency update

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@cgewecke cgewecke added 1.x 1.0 related issues dependencies Review Needed Maintainer(s) need to review labels Mar 4, 2020
@coveralls
Copy link

coveralls commented Mar 4, 2020

Coverage Status

Coverage remained the same at 86.047% when pulling 8dcb24d on issue/3399 into a25ba79 on 1.x.

@rraina
Copy link

rraina commented Mar 19, 2020

Hey Team -- do we know that is blocking this PR from getting merged?

@cgewecke
Copy link
Collaborator Author

@rraina There's no blocker - this will go in the next release.

Fwiw the security vuln at issue here does not actually impact this project - decompress is never loaded in Web3's code. The change is cosmetic.

@rraina
Copy link

rraina commented Mar 19, 2020

@cgewecke -- Thanks for the prompt response!

Completely understand that this is just a cosmetic change; it's just a little annoying since it causes errors on our CI process :)

@cgewecke
Copy link
Collaborator Author

@rraina Yes, understood - it's annoying. Just mentioning it in case there's real concern about whether the dep is safe.

@rraina
Copy link

rraina commented Mar 19, 2020

Yup - thank you for clarifying, and your efforts on this project!

Hope you are keeping safe!

@holgerd77 holgerd77 merged commit dee72e0 into 1.x Mar 20, 2020
@holgerd77 holgerd77 deleted the issue/3399 branch March 20, 2020 22:04
@evertonfraga
Copy link

Thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swarm.js - Arbitrary File Write vulnerability
7 participants