Build is smaller on second install? #3263
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NB: PR targets #3262 which standardizes the bn.js version across the project
PR reduces the bundlesize ~20%, but in a way that is super weird. Suggests something is wrong with the way browserify de-duplicates things in a lerna monorepo.
TLDR; if you install the project and then go to packages/web3 (the bundle entry point) and install the most widely duplicated deps there, there's a big bundle reduction.
Also tried browserify's
preserveSymlinks
option to address this and was quickly OOM within 4GB - @nivida was this the same thing you were seeing when you looked at this in October?[EDITED notes...]
treat the published min as a convenience and not worry about it's size too much (although it would be great to get something on the CDN that was small)