This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Force toBlock not being set when calling myContract.events.<eventName> or myContract.events.allEvents
#3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachomazzara
changed the title
toBlock not being set when calling myContract.events.<eventName> or myContract.events.allEvents
|
See this commint to better understand the change. The files had a wrong format based on the .editorconfig rules. |
|
Looks like those automated tests hung. |
|
Do we want it? I can resolve the conflicts |
|
@nachomazzara that would be awesome, thank you |
|
@nachomazzara when you get a chance to update the branch, could you leave out any lint/format changes for now? just so we have a clean diff of just the most relevant changes. it looks good though and i hope to include this in v1.2.10 |
…sonal, eth, and shh
…d web3-core. Constructor types updated to improve TS DX
…, core, and core-helpers package
…mber) and BlockNumber type in web3-core extended with BigNumber
The position parameter was set as number, but a string is required to specify a position for a slot with a large index (ie greater than 53 bits) since it requires more precision that js max int.
…ed version, CHANGELOG updated and new web3 version defined if required
…s to the root README file with all the required details
…te smaller bundles without the 'browser' entry it's webpack who can't handle this that good
|
Closed By #3567 |
|
@nachomazzara no problem, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Throw if
toBlockis set when callingmyContract.events.<eventName>ormyContract.events.allEventsFixes #3207
Type of change
toBlock: 'latest'