Skip to content
This repository has been archived by the owner on Mar 5, 2025. It is now read-only.

update shh doc for post to promise usage #1545

Merged
merged 1 commit into from
Apr 13, 2018
Merged

update shh doc for post to promise usage #1545

merged 1 commit into from
Apr 13, 2018

Conversation

gballet
Copy link
Contributor

@gballet gballet commented Apr 12, 2018

The documentation for post in web3-shh is still mentioning callbacks and a Boolean return value. This is no longer the case and this PR fixes the documentation on this point.

@gballet gballet mentioned this pull request Apr 12, 2018
Merged
@coveralls
Copy link

coveralls commented Apr 12, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 85.746% when pulling d6993df on gballet:shh-post-promise-doc-update into e69054d on ethereum:1.0.

@frozeman frozeman merged commit 1ebfbd9 into web3:1.0 Apr 13, 2018
@frozeman
Copy link
Contributor

Thanks

nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@gballet @nachomazzara
update shh doc for post to promise usage (web3#1545)
04e6342
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gballet @coveralls @frozeman