fix: unnecessary array copy when pack encoding

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
web3 · Oct 25, 2023 · 9606f73 · 9606f73
1 parent f860b04
commit 9606f73
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/web3-utils/CHANGELOG.md b/packages/web3-utils/CHANGELOG.md
@@ -169,4 +169,8 @@ Documentation:
 -   Fix issue with default config with babel (and React): "TypeError: Cannot convert a BigInt value to a number #6187" (#6506)
 -   Fixed bug in chunks processing logic (#6496)
 
-## [Unreleased]
+## [Unreleased]
+
+### Fixed
+
+-   Fix unecessary array copy when pack encoding
diff --git a/packages/web3-utils/src/hash.ts b/packages/web3-utils/src/hash.ts
@@ -325,7 +325,10 @@ export const processSolidityEncodePackedArgs = (arg: Sha3Input): string => {
  * Encode packed arguments to a hexstring
  */
 export const encodePacked = (...values: Sha3Input[]): string => {
-	const args = Array.prototype.slice.call(values);
+	let args = values;
+	if(!Array.isArray(values)) {
+		args = [values]
+	}
 	const hexArgs = args.map(processSolidityEncodePackedArgs);
 	return `0x${hexArgs.join('').toLowerCase()}`;
 };