Merge pull request #3326 from ethereum/issue/3319

Add types for subscription.on(connected)

CHANGELOG.md

@@ -137,3 +137,7 @@ Released with 1.0.0-beta.37 code base.
 ### Changed
 
 - Ensure '0x' prefix is existing for Accounts.sign and Accounts.privateKeyToAccount (#3041)
+
+### Fixed
+
+- Add missing subscription.on('connected') TS type definition (#3319)

packages/web3-core-subscriptions/types/index.d.ts

@@ -35,6 +35,8 @@ export class Subscription<T> {
 
     on(type: 'changed', handler: (data: T) => void): Subscription<T>;
 
+    on(type: 'connected', handler: (subscriptionId: string) => void): Subscription<T>;
+
     on(type: 'error', handler: (data: Error) => void): Subscription<T>;
 }
 

packages/web3-core-subscriptions/types/tests/subscriptions.tests.ts

@@ -83,3 +83,6 @@ subscription.on('changed', () => {});
 
 // $ExpectType Subscription<unknown>
 subscription.on('error', () => {});
+
+// $ExpectType Subscription<unknown>
+subscription.on('connected', () => {});

scripts/e2e.mosaic.sh

@@ -31,7 +31,7 @@ echo "Installing updated web3 via virtual registry "
 echo ">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>"
 
 git submodule update --init --recursive
-yarn --registry http://localhost:4873
+yarn --registry http://localhost:4873 --network-timeout 100000
 
 yarn add web3@e2e --registry http://localhost:4873 --network-timeout 100000