add unit tests

packages/web3-eth-ens/CHANGELOG.md

@@ -147,4 +147,8 @@ Documentation:
 
 -   Added function `setAddress` in ENS and Resolver classes (#5956)
 
-## [Unreleased]
+## [Unreleased]
+
+### Add
+
+- Added function getText and getName in ENS and resolver classes

packages/web3-eth-ens/src/config.ts

@@ -29,7 +29,7 @@ export const interfaceIds: { [T: string]: string } = {
 };
 
 /**
- * An object holding the functionsthat are supported by the ENS resolver contracts/interfaces.
+ * An object holding the functions that are supported by the ENS resolver contracts/interfaces.
  */
 export const methodsInInterface: { [T: string]: string } = {
 	setAddr: 'addr',
@@ -38,6 +38,8 @@ export const methodsInInterface: { [T: string]: string } = {
 	pubkey: 'pubkey',
 	setContenthash: 'contenthash',
 	contenthash: 'contenthash',
+	text: 'text',
+	name: 'name',
 };
 
 /**

packages/web3-eth-ens/src/ens.ts

@@ -167,9 +167,22 @@ export class ENS extends Web3Context<EthExecutionAPI & Web3NetAPI> {
 
 	/**
 	 * ERC-634 - Returns the text content stored in the resolver for the specified key.
+	 * @param ENSName - The ENS name to resolve
+	 * @param key - The key to resolve https://github.com/ethereum/ercs/blob/master/ERCS/erc-634.md#global-keys
+	 * @returns - The value content stored in the resolver for the specified key
 	 */
 	public async getText(ENSName: string, key: string): Promise<string> {
-		return this._resolver.text(ENSName, key);
+		return this._resolver.getText(ENSName, key);
+	}
+
+
+	/**
+	 * Resolves an ENS name to an Ethereum address.
+	 * @param address - The address to resolve
+	 * @returns - The ENS name of the given address
+	 */
+	public async getName(address: string): Promise<string> {
+		return this._resolver.getName(address);
 	}
 
 	/**

packages/web3-eth-ens/src/resolver.ts

@@ -130,12 +130,12 @@ export class Resolver {
 	}
 
 	public async getName(
-		ENSName: string
+		address: string
 	) {
-		const resolverContract = await this.getResolverContractAdapter(ENSName);
+		const resolverContract = await this.getResolverContractAdapter(address);
 		await this.checkInterfaceSupport(resolverContract, methodsInInterface.name);
 
 		return resolverContract.methods
-			.name(namehash(ENSName)).call()
+			.name(namehash(address)).call()
 	}
 }

packages/web3-eth-ens/test/unit/resolver.test.ts

@@ -211,6 +211,60 @@ describe('resolver', () => {
 		});
 	});
 
+	describe('text', () => {
+		it('getText', async () => {
+			const supportsInterfaceMock = jest
+				.spyOn(contract.methods, 'supportsInterface')
+				.mockReturnValue({
+					call: async () => Promise.resolve(true),
+				} as unknown as NonPayableMethodObject<any, any>);
+
+				const textMock = jest.spyOn(contract.methods, 'text').mockReturnValue({
+					call: jest.fn(),
+				} as unknown as NonPayableMethodObject<any, any>);
+
+				jest.spyOn(registry, 'getResolver').mockImplementation(async () => {
+					return new Promise(resolve => {
+						resolve(contract);
+					});
+				});
+
+				await resolver.getText(ENS_NAME, "key");
+				expect(supportsInterfaceMock).toHaveBeenCalledWith(
+					interfaceIds[methodsInInterface.text],
+				);
+				expect(textMock).toHaveBeenCalledWith(namehash(ENS_NAME), "key");
+	})
+})
+
+	describe('name', () => {
+		it('getName', async () => {
+			const supportsInterfaceMock = jest
+				.spyOn(contract.methods, 'supportsInterface')
+				.mockReturnValue({
+					call: async () => Promise.resolve(true),
+				} as unknown as NonPayableMethodObject<any, any>);
+
+				const nameMock = jest.spyOn(contract.methods, 'name').mockReturnValue({
+					call: jest.fn(),
+				} as unknown as NonPayableMethodObject<any, any>);
+
+				jest.spyOn(registry, 'getResolver').mockImplementation(async () => {
+					return new Promise(resolve => {
+						resolve(contract);
+					});
+				});
+
+				await resolver.getName(ENS_NAME);
+				expect(supportsInterfaceMock).toHaveBeenCalledWith(
+					interfaceIds[methodsInInterface.name],
+				);
+
+				expect(nameMock).toHaveBeenCalledWith(namehash(ENS_NAME));
+		})
+	})
+
+
 	describe('supportsInterface', () => {
 		it('check supportsInterface for non strict hex id', async () => {
 			const interfaceId = 'setAddr';