Fix Typos in Queries for GetTaskList() #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElanHasson
temporarily deployed
to
DOCR registry.digitalocean.com/web-scheduler
GitHub Actions
Inactive
ElanHasson
commented
Jan 21, 2023
| @@ -128,7 +128,7 @@ FROM OrleansStorage | |||
| AND IsScheduledTaskDeleted = false | |||
| AND GrainTypeHash=2108290596 | |||
| ORDER BY ScheduledTaskCreatedAt ASC | |||
| LIMIT @Offset, @PageSize; | |||
| LIMIT @Offset, @PageSize"; | |||
There was a problem hiding this comment.
The extra quote snuck in again.
ElanHasson
commented
Jan 21, 2023
| @@ -197,9 +197,7 @@ FROM OrleansStorage | |||
| WHERE | |||
| TenantId = @TenantId | |||
| AND IsScheduledTaskDeleted = false | |||
| AND GrainTypeHash=2108290596 | |||
| ORDER BY ScheduledTaskCreatedAt ASC | |||
There was a problem hiding this comment.
Note on line 205 we don't set Pagination values nor do we need to order the count of the set.
ElanHasson
temporarily deployed
to
GitHub Packages
GitHub Actions
Inactive
ElanHasson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.